Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 760423002: Removing unused function isVertical(). (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing unused function isVertical(). A new API called orientation() has been introduced hence no need to keep isvertical(). This CL depends on https://codereview.chromium.org/744623002/ BUG=416763 TBR=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M Source/web/WebAXObject.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M public/web/WebAXObject.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
shreeramk
Please review. Thanks!!
6 years ago (2014-12-01 06:52:50 UTC) #2
dmazzoni
lgtm +mkwst as TBR
6 years ago (2014-12-01 06:54:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760423002/1
6 years ago (2014-12-01 06:55:10 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-01 07:31:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186215

Powered by Google App Engine
This is Rietveld 408576698