Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 760383005: Fix parallel move code for swapping SIMD registers on ARM and ARM64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm.cc (revision 42037)
+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)
@@ -1690,11 +1690,19 @@
Exchange(source.base_reg(), source.ToStackSlotOffset(),
destination.base_reg(), destination.ToStackSlotOffset());
} else if (source.IsFpuRegister() && destination.IsFpuRegister()) {
- const DRegister dst = EvenDRegisterOf(destination.fpu_reg());
- DRegister src = EvenDRegisterOf(source.fpu_reg());
- __ vmovd(DTMP, src);
- __ vmovd(src, dst);
- __ vmovd(dst, DTMP);
+ if (TargetCPUFeatures::neon_supported()) {
+ QRegister dst = destination.fpu_reg();
zerny-google 2014/12/01 15:23:02 Nit: should we keep const here and below?
Florian Schneider 2014/12/01 15:24:40 Done.
+ QRegister src = source.fpu_reg();
+ __ vmovq(QTMP, src);
+ __ vmovq(src, dst);
+ __ vmovq(dst, QTMP);
+ } else {
+ DRegister dst = EvenDRegisterOf(destination.fpu_reg());
+ DRegister src = EvenDRegisterOf(source.fpu_reg());
+ __ vmovd(DTMP, src);
+ __ vmovd(src, dst);
+ __ vmovd(dst, DTMP);
+ }
} else if (source.IsFpuRegister() || destination.IsFpuRegister()) {
ASSERT(destination.IsDoubleStackSlot() ||
destination.IsQuadStackSlot() ||
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698