Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 760283005: Version 3.29.88.19 (cherry-pick) (Closed)

Created:
6 years ago by Yang
Modified:
6 years ago
CC:
ulan, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@3.29
Project:
v8
Visibility:
Public.

Description

Version 3.29.88.19 (cherry-pick) Merged b9583b5f988cb6b8f369fe9c64b1b6db58c86589 String::NewExternal should not crash the renderer. BUG=414615 LOG=N R=jochen@chromium.org TBR=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=02f2ff3aa2b35e05b61bf8b60021a888de0064fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -19 lines) Patch
M src/api.cc View 3 chunks +19 lines, -18 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years ago (2014-12-04 09:41:25 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-04 09:42:06 UTC) #2
Yang
6 years ago (2014-12-04 09:50:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
02f2ff3aa2b35e05b61bf8b60021a888de0064fa.

Powered by Google App Engine
This is Rietveld 408576698