LayoutTests/http/tests/permissions/test-api-surface.html - Issue 760223003: Stub implementation of Permissions API module.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/permissions/test-api-surface.html

Issue 760223003: Stub implementation of Permissions API module. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: no copies Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/permissions/resources/helpers.js ('K') | « LayoutTests/http/tests/permissions/resources/test-query.js ('k') | LayoutTests/http/tests/permissions/test-query.html » ('j') | Source/modules/permissions/PermissionStatus.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Permissions API: test API surface.</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="../serviceworker/resources/test-helpers.js"></script>

	8 <script src="resources/helpers.js"></script>

	9 </head>

	10 <body>

	11 <!--

	12 This test file automatically run the .js file with the same name in the

	13 resources/ directory.
	Peter Beverloo 2014/12/01 11:30:35 Can we make this explicit, rather than magical? < Can we make this explicit, rather than magical? <script> runTest('resources/test-api-surface.js'); </script> Imagine a situation in which this test is flaky. Explicitly calling a method executing the tests is much clearer and easier to triage for people unfamiliar with these tests than an if-statement in a file that's being included by both the .html and .js pages. It's also not obvious that the test will be ran in four different contexts: Documents, Dedicated Workers, Shared Workers and Service Workers. When running the test manually, what does the output look like? Is it clear which part of the test is failing? mlamouri (slow - plz ping) 2014/12/01 12:36:00 Yeah, I agree, it's a bit too magical. I've added Show quoted text On 2014/12/01 at 11:30:35, Peter Beverloo wrote: > Can we make this explicit, rather than magical? > > <script> > runTest('resources/test-api-surface.js'); > </script> > > Imagine a situation in which this test is flaky. Explicitly calling a method executing the tests is much clearer and easier to triage for people unfamiliar with these tests than an if-statement in a file that's being included by both the .html and .js pages. > > It's also not obvious that the test will be ran in four different contexts: Documents, Dedicated Workers, Shared Workers and Service Workers. When running the test manually, what does the output look like? Is it clear which part of the test is failing? Yeah, I agree, it's a bit too magical. I've added a runTest() method. The error will specify the scope.
	14 -->

	15 </body>

	16 </html>

OLD	NEW