src/objects-inl.h - Issue 760213005: Turn on DCHECKs and other debugging code if dcheck_always_on is 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 760213005: Turn on DCHECKs and other debugging code if dcheck_always_on is 1 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index f6f47e547606f8c7dfc89685504b8004adbe81e8..a8904514268e239aef8d8803c089bebba9d5cecb 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -6548,7 +6548,7 @@ void JSRegExp::SetDataAt(int index, Object* value) {

ElementsKind JSObject::GetElementsKind() {

ElementsKind kind = map()->elements_kind();

-#if DEBUG

+#if VERIFY_HEAP

FixedArrayBase* fixed_array =

reinterpret_cast<FixedArrayBase*>(READ_FIELD(this, kElementsOffset));

« src/objects.h ('K') | « src/objects.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »