src/api.cc - Issue 760213005: Turn on DCHECKs and other debugging code if dcheck_always_on is 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 760213005: Turn on DCHECKs and other debugging code if dcheck_always_on is 1 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index cc0f70bf318c5f57fca3e49c5d5c9d7daaf9a3ff..3069bc5e1a9d94728695db96fd38b5e313831250 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -339,7 +339,7 @@ void SetResourceConstraints(i::Isolate* isolate,

i::Object** V8::GlobalizeReference(i::Isolate* isolate, i::Object** obj) {

LOG_API(isolate, "Persistent::New");

i::Handle<i::Object> result = isolate->global_handles()->Create(*obj);

-#ifdef DEBUG

+#ifdef VERIFY_HEAP

(*obj)->ObjectVerify();

#endif // DEBUG

Jakob Kummerow 2014/12/04 08:59:45 nit: s/DEBUG/VERIFY_HEAP/, again below

return result.location();

@@ -348,7 +348,7 @@ i::Object** V8::GlobalizeReference(i::Isolate* isolate, i::Object** obj) {

i::Object** V8::CopyPersistent(i::Object** obj) {

i::Handle<i::Object> result = i::GlobalHandles::CopyGlobal(obj);

-#ifdef DEBUG

+#ifdef VERIFY_HEAP

(*obj)->ObjectVerify();

#endif // DEBUG

return result.location();

« no previous file with comments | « build/toolchain.gypi ('k') | src/checks.h » ('j') | src/objects.h » ('J')