src/jsregexp.cc - Issue 760213005: Turn on DCHECKs and other debugging code if dcheck_always_on is 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/jsregexp.cc

Issue 760213005: Turn on DCHECKs and other debugging code if dcheck_always_on is 1 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updaets Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/jsregexp.cc

diff --git a/src/jsregexp.cc b/src/jsregexp.cc

index a9fdc570822df13c8d272cbbf4f2dd2fa306bdfa..63599c8127d1e0689896bf7e67543a0ddabb39e8 100644

--- a/src/jsregexp.cc

+++ b/src/jsregexp.cc

@@ -1104,12 +1104,14 @@ RegExpEngine::CompilationResult RegExpCompiler::Assemble(

Handle<HeapObject> code = macro_assembler_->GetCode(pattern);

heap->IncreaseTotalRegexpCodeGenerated(code->Size());

work_list_ = NULL;

-#ifdef DEBUG

+#ifdef ENABLE_DISASSEMBLER

if (FLAG_print_code) {

CodeTracer::Scope trace_scope(heap->isolate()->GetCodeTracer());

OFStream os(trace_scope.file());

Handle<Code>::cast(code)->Disassemble(pattern->ToCString().get(), os);

}

+#endif

+#ifdef DEBUG

if (FLAG_trace_regexp_assembler) {

delete macro_assembler_;

}

« no previous file with comments | « src/checks.h ('k') | src/objects.h » ('j') | no next file with comments »