Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: build/features.gypi

Issue 760213005: Turn on DCHECKs and other debugging code if dcheck_always_on is 1 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updaets Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/toolchain.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 # Enable ECMAScript Internationalization API. Enabling this feature will 55 # Enable ECMAScript Internationalization API. Enabling this feature will
56 # add a dependency on the ICU library. 56 # add a dependency on the ICU library.
57 'v8_enable_i18n_support%': 1, 57 'v8_enable_i18n_support%': 1,
58 58
59 # Enable compiler warnings when using V8_DEPRECATED apis. 59 # Enable compiler warnings when using V8_DEPRECATED apis.
60 'v8_deprecation_warnings%': 0, 60 'v8_deprecation_warnings%': 0,
61 61
62 # Use external files for startup data blobs: 62 # Use external files for startup data blobs:
63 # the JS builtins sources and the start snapshot. 63 # the JS builtins sources and the start snapshot.
64 'v8_use_external_startup_data%': 0, 64 'v8_use_external_startup_data%': 0,
65
66 # Set to 1 to enable DCHECKs in release builds.
67 'dcheck_always_on%': 0,
65 }, 68 },
66 'target_defaults': { 69 'target_defaults': {
67 'conditions': [ 70 'conditions': [
68 ['v8_enable_disassembler==1', { 71 ['v8_enable_disassembler==1', {
69 'defines': ['ENABLE_DISASSEMBLER',], 72 'defines': ['ENABLE_DISASSEMBLER',],
70 }], 73 }],
71 ['v8_enable_gdbjit==1', { 74 ['v8_enable_gdbjit==1', {
72 'defines': ['ENABLE_GDB_JIT_INTERFACE',], 75 'defines': ['ENABLE_GDB_JIT_INTERFACE',],
73 }], 76 }],
74 ['v8_object_print==1', { 77 ['v8_object_print==1', {
(...skipping 13 matching lines...) Expand all
88 }], 91 }],
89 ['v8_deprecation_warnings==1', { 92 ['v8_deprecation_warnings==1', {
90 'defines': ['V8_DEPRECATION_WARNINGS',], 93 'defines': ['V8_DEPRECATION_WARNINGS',],
91 }], 94 }],
92 ['v8_enable_i18n_support==1', { 95 ['v8_enable_i18n_support==1', {
93 'defines': ['V8_I18N_SUPPORT',], 96 'defines': ['V8_I18N_SUPPORT',],
94 }], 97 }],
95 ['v8_use_external_startup_data==1', { 98 ['v8_use_external_startup_data==1', {
96 'defines': ['V8_USE_EXTERNAL_STARTUP_DATA',], 99 'defines': ['V8_USE_EXTERNAL_STARTUP_DATA',],
97 }], 100 }],
101 ['dcheck_always_on!=0', {
102 'defines': ['DEBUG',],
103 }],
98 ], # conditions 104 ], # conditions
99 'configurations': { 105 'configurations': {
100 'DebugBaseCommon': { 106 'DebugBaseCommon': {
101 'abstract': 1, 107 'abstract': 1,
102 'variables': { 108 'variables': {
103 'v8_enable_extra_checks%': 1, 109 'v8_enable_extra_checks%': 1,
104 'v8_enable_handle_zapping%': 1, 110 'v8_enable_handle_zapping%': 1,
105 }, 111 },
106 'conditions': [ 112 'conditions': [
107 ['v8_enable_extra_checks==1', { 113 ['v8_enable_extra_checks==1', {
(...skipping 14 matching lines...) Expand all
122 'defines': ['ENABLE_EXTRA_CHECKS',], 128 'defines': ['ENABLE_EXTRA_CHECKS',],
123 }], 129 }],
124 ['v8_enable_handle_zapping==1', { 130 ['v8_enable_handle_zapping==1', {
125 'defines': ['ENABLE_HANDLE_ZAPPING',], 131 'defines': ['ENABLE_HANDLE_ZAPPING',],
126 }], 132 }],
127 ], # conditions 133 ], # conditions
128 }, # Release 134 }, # Release
129 }, # configurations 135 }, # configurations
130 }, # target_defaults 136 }, # target_defaults
131 } 137 }
OLDNEW
« no previous file with comments | « no previous file | build/toolchain.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698