sky/engine/core/dom/Document.cpp - Issue 760183003: Enable/Unprefix Animations & Transitions, add basic tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/Document.cpp

Issue 760183003: Enable/Unprefix Animations & Transitions, add basic tests (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/engine/core/css/parser/CSSTokenizer-in.cpp ('k') | sky/engine/core/events/AnimationPlayerEvent.idl » ('j') | sky/tests/animation/basic-declarative.sky » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/dom/Document.cpp

diff --git a/sky/engine/core/dom/Document.cpp b/sky/engine/core/dom/Document.cpp

index ed0147ddc350319815f96f575867728f51c64d72..fac351b476af4824be1eb354a7964faf13515e75 100644

--- a/sky/engine/core/dom/Document.cpp

+++ b/sky/engine/core/dom/Document.cpp

@@ -2067,13 +2067,13 @@ PassRefPtr<Event> Document::createEvent(const String& eventType, ExceptionState&

void Document::addListenerTypeIfNeeded(const AtomicString& eventType)

{

- if (eventType == EventTypeNames::webkitAnimationStart || (RuntimeEnabledFeatures::cssAnimationUnprefixedEnabled() && eventType == EventTypeNames::animationstart)) {

+ if (eventType == EventTypeNames::animationstart) {

addListenerType(ANIMATIONSTART_LISTENER);

- } else if (eventType == EventTypeNames::webkitAnimationEnd || (RuntimeEnabledFeatures::cssAnimationUnprefixedEnabled() && eventType == EventTypeNames::animationend)) {

+ } else if (eventType == EventTypeNames::animationend) {

addListenerType(ANIMATIONEND_LISTENER);

- } else if (eventType == EventTypeNames::webkitAnimationIteration || (RuntimeEnabledFeatures::cssAnimationUnprefixedEnabled() && eventType == EventTypeNames::animationiteration)) {

+ } else if (eventType == EventTypeNames::animationiteration) {

addListenerType(ANIMATIONITERATION_LISTENER);

- } else if (eventType == EventTypeNames::webkitTransitionEnd || eventType == EventTypeNames::transitionend) {

+ } else if (eventType == EventTypeNames::transitionend) {

addListenerType(TRANSITIONEND_LISTENER);

} else if (eventType == EventTypeNames::scroll) {

addListenerType(SCROLL_LISTENER);