Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 760183003: Enable/Unprefix Animations & Transitions, add basic tests (Closed)

Created:
6 years ago by rafaelw
Modified:
6 years ago
Reviewers:
esprehn, ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Enable/Unprefix Animations & Transitions, add basic tests This patch remove the Web Animations & CSS Animation runtime flags (and enables both). Removes prefixed Aninamations & Transitions and adds some basic tests & test support API. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8514445343682a5a9db150ad851f8df01830ce88

Patch Set 1 #

Total comments: 4

Patch Set 2 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -482 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +12 lines, -12 lines 0 comments Download
M sky/engine/core/animation/Animation.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/animation/Animation.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationEffect.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationNode.idl View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/animation/AnimationPlayer.idl View 1 chunk +11 lines, -11 lines 0 comments Download
M sky/engine/core/animation/AnimationTimeline.idl View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/animation/DocumentAnimation.idl View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/animation/ElementAnimation.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/Timing.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSAnimations.cpp View 2 chunks +1 line, -15 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 9 chunks +7 lines, -41 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 5 chunks +15 lines, -30 lines 0 comments Download
M sky/engine/core/css/CSSProperty.h View 1 chunk +0 lines, -71 lines 0 comments Download
M sky/engine/core/css/StylePropertySerializer.cpp View 4 chunks +9 lines, -19 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.h View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.cpp View 4 chunks +3 lines, -58 lines 0 comments Download
M sky/engine/core/css/StylePropertyShorthandCustom.cpp View 3 chunks +2 lines, -44 lines 0 comments Download
M sky/engine/core/css/parser/CSSGrammar.y View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 11 chunks +8 lines, -60 lines 0 comments Download
M sky/engine/core/css/parser/CSSTokenizer-in.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/engine/core/events/AnimationPlayerEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/EventAliases.in View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/EventTarget.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/EventTarget.cpp View 3 chunks +0 lines, -57 lines 0 comments Download
M sky/engine/core/events/EventTypeNames.in View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/platform/RuntimeEnabledFeatures.in View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebDocument.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/web/WebDocument.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M sky/engine/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A sky/tests/animation/basic-declarative.sky View 1 1 chunk +31 lines, -0 lines 0 comments Download
A sky/tests/animation/basic-declarative-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A sky/tests/animation/basic-imperative.sky View 1 chunk +16 lines, -0 lines 0 comments Download
A sky/tests/animation/basic-imperative-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A sky/tests/animation/basic-transition.sky View 1 1 chunk +31 lines, -0 lines 0 comments Download
A sky/tests/animation/basic-transition-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/tools/third_party/PrettyPatch/PrettyPatch.rb View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/viewer/internals.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/viewer/internals.cc View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rafaelw
6 years ago (2014-12-10 02:57:16 UTC) #2
ojan
lgtm https://codereview.chromium.org/760183003/diff/1/sky/tests/animation/basic-declarative.sky File sky/tests/animation/basic-declarative.sky (right): https://codereview.chromium.org/760183003/diff/1/sky/tests/animation/basic-declarative.sky#newcode26 sky/tests/animation/basic-declarative.sky:26: internals.pauseAnimations(3); Nit: indentation https://codereview.chromium.org/760183003/diff/1/sky/tests/animation/basic-transition.sky File sky/tests/animation/basic-transition.sky (right): https://codereview.chromium.org/760183003/diff/1/sky/tests/animation/basic-transition.sky#newcode7 ...
6 years ago (2014-12-10 03:48:17 UTC) #3
rafaelw
https://codereview.chromium.org/760183003/diff/1/sky/tests/animation/basic-declarative.sky File sky/tests/animation/basic-declarative.sky (right): https://codereview.chromium.org/760183003/diff/1/sky/tests/animation/basic-declarative.sky#newcode26 sky/tests/animation/basic-declarative.sky:26: internals.pauseAnimations(3); On 2014/12/10 03:48:16, ojan wrote: > Nit: indentation ...
6 years ago (2014-12-10 18:30:24 UTC) #4
rafaelw
6 years ago (2014-12-10 18:38:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8514445343682a5a9db150ad851f8df01830ce88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698