Issue 760143002: Make fixed-width elements not center by default.

Issue 760143002: Make fixed-width elements not center by default. (Closed)

Created:
6 years ago by ojan

Modified:
6 years ago

Reviewers:
abarth-chromium, esprehn, rafaelw, eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Make fixed-width elements not center by default. e223e0c6d51f027196a2597b556641328a65d4b5 accidentally sent all elements down the margin:auto codepath. The patch incorrectly removed just the "&& containingBlockStyle->textAlign() == WEBKIT_CENTER" instead of the whole clause. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/13b84227f19a0c07b3242d688ca0c50310e5d1a2

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -13 lines)			Patch
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/tests/layout/ellipsis-expected.txt	View	1 chunk	+5 lines, -5 lines	0 comments	Download
A	sky/tests/layout/fixed-width.sky	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	sky/tests/layout/fixed-width-expected.txt	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sky/tests/lowlevel/iframe-expected.txt	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sky/tests/lowlevel/img-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

6 years ago (2014-11-26 23:25:09 UTC) #6

ojan

6 years ago (2014-11-27 00:39:45 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
13b84227f19a0c07b3242d688ca0c50310e5d1a2 (presubmit successful).