Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: pkg/polymer/lib/src/build/linter.dart

Issue 76013002: "Reverting 30387" -- failures on IE (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/polymer/lib/src/declaration.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/build/linter.dart
diff --git a/pkg/polymer/lib/src/build/linter.dart b/pkg/polymer/lib/src/build/linter.dart
index 3c5fa20d3aff6ceba0af6e67acfa860ff9becff4..f186d310191507ed4561d7825fb29d3b50faafa9 100644
--- a/pkg/polymer/lib/src/build/linter.dart
+++ b/pkg/polymer/lib/src/build/linter.dart
@@ -254,6 +254,11 @@ class _LinterVisitor extends TreeVisitor {
if (_isEntrypoint && !_dartTagSeen) {
_logger.error(USE_INIT_DART, span: doc.body.sourceSpan);
}
+
+ if (_isEntrypoint && !_dartJSSeen) {
+ // TODO(sigmund): remove this when webkitStartDart is gone.
+ _logger.error(USE_DART_JS, span: doc.body.sourceSpan);
+ }
}
/** Produce warnings for invalid link-rel tags. */
@@ -491,6 +496,15 @@ class _LinterVisitor extends TreeVisitor {
span: node.attributeSpans[name]);
}
+ var eventName = name.substring('on-'.length);
+ if (eventName.contains('-')) {
+ var newEvent = toCamelCase(eventName);
+ _logger.warning('Invalid event name "$name". After the "on-" the event '
+ 'name should not use dashes. For example use "on-$newEvent" or '
+ '"on-${newEvent.toLowerCase()}" (both forms are equivalent in HTML).',
+ span: node.attributeSpans[name]);
+ }
+
if (value.contains('.') || value.contains('(')) {
_logger.warning('Invalid event handler body "$value". Declare a method '
'in your custom element "void handlerName(event, detail, target)" '
@@ -528,12 +542,16 @@ const String _MAGENTA_COLOR = '\u001b[35m';
const String _NO_COLOR = '\u001b[0m';
const String USE_INIT_DART =
- 'To run a polymer application, you need to call "initPolymer". You can '
+ 'To run a polymer applications, you need to call "initPolymer". You can '
'either include a generic script tag that does this for you:'
'\'<script type="application/dart">export "package:polymer/init.dart";'
'</script>\' or add your own script tag and call that function. '
'Make sure the script tag is placed after all HTML imports.';
+const String USE_DART_JS =
+ 'To run a polymer applications in Dartium, make sure to include'
+ '\'<script src="packages/browser/dart.js"></script>\' in your page';
+
const String BOOT_JS_DEPRECATED =
'"boot.js" is now deprecated. Instead, you can initialize your polymer '
'application by calling "initPolymer()" in your main. If you don\'t have a '
« no previous file with comments | « no previous file | pkg/polymer/lib/src/declaration.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698