Issue 760063002: Abort optimization in corner case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 760063002: Abort optimization in corner case. (Closed)

Created:
6 years ago by titzer

Modified:
6 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Abort optimization in corner case. The %OptimizeFunctionOnNextCall sledgehammer can cause a function to be marked for optimization before it's ever been compiled by fullcode. This can lead to the situation where a function doesn't have optimization disabled until we try to compile it optimized. Basically, the assert should just handle this case more gracefully. R=yangguo@chromium.org BUG=436893 LOG=Y

Patch Set 1 #

Patch Set 2 : Add testcase. #

Patch Set 3 : #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -16 lines)			Patch
M	src/compiler.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/runtime/runtime-test.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-436893.js	View	1	2 chunks	+7 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760063002/40001

6 years ago (2014-11-26 16:22:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages