Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 760023004: Copy src in SkDrawLooper::computeFastBounds(). (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Copy src in SkDrawLooper::computeFastBounds(). We do alias src and dst when building the BBH. This meant we calculated the wrong bounds in LayoutTests/ietestcenter/css3/text/textshadow-010.htm. Not sure how best to test this inside Skia. It may become moot after I work through the API changes we were talking about today, but if not I'll make sure it's tested somehow before I'm done with SkDrawLoopers. BUG=skia:3186 Committed: https://skia.googlesource.com/skia/+/96a6c4df417a2382dd183b0dbc1c614819795f2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/core/SkDrawLooper.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years ago (2014-12-03 18:57:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760023004/1
6 years ago (2014-12-03 18:58:15 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-03 18:58:16 UTC) #5
reed1
6 years ago (2014-12-03 18:58:58 UTC) #6
reed1
lgtm
6 years ago (2014-12-03 18:59:48 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-03 19:08:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/96a6c4df417a2382dd183b0dbc1c614819795f2a

Powered by Google App Engine
This is Rietveld 408576698