Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 760023002: add sample to exercise hittesting (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add sample to exercising hittesting patch from issue 752403002 at patchset 1 (http://crrev.com/752403002#ps1) BUG=skia: Committed: https://skia.googlesource.com/skia/+/adc8d984678a64e30f3c70b2d76ba1e8345566bb

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : revert hack to Enabler #

Patch Set 4 : cleanup sample #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -0 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A samplecode/SampleHT.cpp View 1 2 3 1 chunk +171 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
reed1
6 years ago (2014-11-26 13:59:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760023002/20001
6 years ago (2014-11-26 13:59:29 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-11-26 13:59:29 UTC) #5
tfarina
https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp File samplecode/SampleHT.cpp (right): https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp#newcode3 samplecode/SampleHT.cpp:3: * Copyright 2011 Google Inc. s/2011/2014?
6 years ago (2014-11-26 14:10:09 UTC) #6
reed1
PTAL https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp File samplecode/SampleHT.cpp (right): https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp#newcode3 samplecode/SampleHT.cpp:3: * Copyright 2011 Google Inc. On 2014/11/26 14:10:09, ...
6 years ago (2014-11-26 14:12:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760023002/60001
6 years ago (2014-11-26 14:13:38 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-11-26 14:13:39 UTC) #10
robertphillips
lgtm + nits https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp File samplecode/SampleHT.cpp (right): https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp#newcode2 samplecode/SampleHT.cpp:2: /* 2014 ? https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp#newcode10 samplecode/SampleHT.cpp:10: #include ...
6 years ago (2014-11-26 14:21:35 UTC) #11
reed1
https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp File samplecode/SampleHT.cpp (right): https://codereview.chromium.org/760023002/diff/20001/samplecode/SampleHT.cpp#newcode2 samplecode/SampleHT.cpp:2: /* On 2014/11/26 14:21:35, robertphillips wrote: > 2014 ? ...
6 years ago (2014-11-26 14:25:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760023002/60001
6 years ago (2014-11-26 14:27:09 UTC) #15
commit-bot: I haz the power
6 years ago (2014-11-26 16:45:40 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/adc8d984678a64e30f3c70b2d76ba1e8345566bb

Powered by Google App Engine
This is Rietveld 408576698