content/renderer/media/android/webmediaplayer_android.h - Issue 759933003: Move OnNeedKey() to WebMediaPlayerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 759933003: Move OnNeedKey() to WebMediaPlayerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index 8b003782d3a20bba61309855b51257b935444f52..1134693799a4a4d7382b855d9a93b7c182960f61 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -254,12 +254,9 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,

void OnMediaSourceOpened(blink::WebMediaSource* web_media_source);

- void OnNeedKey(const std::string& type,

+ void OnNeedKey(const std::string& init_data_type,

const std::vector<uint8>& init_data);

- // TODO(xhwang): Implement WebMediaPlayer::setContentDecryptionModule().

- // See: http://crbug.com/224786

protected:

// Helper method to update the playing state.

void UpdatePlayingState(bool is_playing_);