content/browser/renderer_host/p2p/socket_host_tcp.cc - Issue 759923003: Detect situation when there is no missing send completion signal in P2PSocket implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp.cc

Issue 759923003: Detect situation when there is no missing send completion signal in P2PSocket implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/p2p/socket_host_tcp.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_tcp.cc b/content/browser/renderer_host/p2p/socket_host_tcp.cc

index 79f7b14b0b867e34c784a483c24851c9199ea6f8..b382a3edb840fa6496d21e7a6d68f3df98e6c2c4 100644

--- a/content/browser/renderer_host/p2p/socket_host_tcp.cc

+++ b/content/browser/renderer_host/p2p/socket_host_tcp.cc

@@ -401,7 +401,8 @@ void P2PSocketHostTcpBase::HandleWriteResult(int result) {

if (result >= 0) {

write_buffer_->DidConsume(result);

if (write_buffer_->BytesRemaining() == 0) {

- message_sender_->Send(new P2PMsg_OnSendComplete(id_));

+ message_sender_->Send(

+ new P2PMsg_OnSendComplete(id_, P2PSendPacketMetrics()));

if (write_queue_.empty()) {

write_buffer_ = NULL;

} else {

« no previous file with comments | « no previous file | content/browser/renderer_host/p2p/socket_host_udp.cc » ('j') | no next file with comments »