Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: content/renderer/p2p/socket_client.h

Issue 759923003: Detect situation when there is no missing send completion signal in P2PSocket implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/p2p/socket_client.h
diff --git a/content/renderer/p2p/socket_client.h b/content/renderer/p2p/socket_client.h
index d92407cd5c9bf1e6fa83564e8d642449d06c0028..dac4d94efe583bab093da8f082162317f1bcf81c 100644
--- a/content/renderer/p2p/socket_client.h
+++ b/content/renderer/p2p/socket_client.h
@@ -36,15 +36,11 @@ class P2PSocketClient : public base::RefCountedThreadSafe<P2PSocketClient> {
P2PSocketClient() {}
- // Send the |data| to the |address|.
- virtual void Send(const net::IPEndPoint& address,
- const std::vector<char>& data) = 0;
-
// Send the |data| to the |address| using Differentiated Services Code Point
- // |dscp|.
- virtual void SendWithDscp(const net::IPEndPoint& address,
- const std::vector<char>& data,
- const rtc::PacketOptions& options) = 0;
+ // |dscp|. Return value is the unique packet_id for this packet.
+ virtual uint64_t SendWithDscp(const net::IPEndPoint& address,
Sergey Ulanov 2014/12/23 01:11:02 rename this to Send()?
guoweis_left_chromium 2014/12/23 19:08:32 Done.
+ const std::vector<char>& data,
+ const rtc::PacketOptions& options) = 0;
virtual void SetOption(P2PSocketOption option, int value) = 0;

Powered by Google App Engine
This is Rietveld 408576698