content/renderer/p2p/socket_client_delegate.h - Issue 759923003: Detect situation when there is no missing send completion signal in P2PSocket implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/p2p/socket_client_delegate.h

Issue 759923003: Detect situation when there is no missing send completion signal in P2PSocket implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/p2p/socket_client_delegate.h

diff --git a/content/renderer/p2p/socket_client_delegate.h b/content/renderer/p2p/socket_client_delegate.h

index 204d5cd4aabe5c1b51ecd3b306373bc2ceb7b63a..4652bb7d15c97c8649129b025ccff194f41f0019 100644

--- a/content/renderer/p2p/socket_client_delegate.h

+++ b/content/renderer/p2p/socket_client_delegate.h

@@ -31,7 +31,7 @@ class P2PSocketClientDelegate {

P2PSocketClient* client) = 0;

// Called once for each Send() call after the send is complete.

- virtual void OnSendComplete() = 0;

+ virtual void OnSendComplete(const P2PSendPacketMetrics& send_metrics) = 0;

// Called if an non-retryable error occurs.

virtual void OnError() = 0;

« content/renderer/p2p/ipc_socket_factory.cc ('K') | « content/renderer/p2p/socket_client.h ('k') | content/renderer/p2p/socket_client_impl.h » ('j') | no next file with comments »