Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: content/common/p2p_socket_type.h

Issue 759923003: Detect situation when there is no missing send completion signal in P2PSocket implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file defines some basic types used by the P2P-related IPC 5 // This file defines some basic types used by the P2P-related IPC
6 // messages. 6 // messages.
7 7
8 #ifndef CONTENT_COMMON_P2P_SOCKET_TYPE_H_ 8 #ifndef CONTENT_COMMON_P2P_SOCKET_TYPE_H_
9 #define CONTENT_COMMON_P2P_SOCKET_TYPE_H_ 9 #define CONTENT_COMMON_P2P_SOCKET_TYPE_H_
10 10
(...skipping 30 matching lines...) Expand all
41 P2PHostAndIPEndPoint() {} 41 P2PHostAndIPEndPoint() {}
42 P2PHostAndIPEndPoint(const std::string& hostname, 42 P2PHostAndIPEndPoint(const std::string& hostname,
43 const net::IPEndPoint& ip_address) 43 const net::IPEndPoint& ip_address)
44 : hostname(hostname), ip_address(ip_address) { 44 : hostname(hostname), ip_address(ip_address) {
45 } 45 }
46 46
47 std::string hostname; 47 std::string hostname;
48 net::IPEndPoint ip_address; 48 net::IPEndPoint ip_address;
49 }; 49 };
50 50
51 // Stuct which keeps track of metrics during a send operation on P2P sockets.
52 // Currently, it only carries packet_id but could be expanded to include
53 // timestamps when packet arrives at various points.
Sergey Ulanov 2014/12/16 00:21:43 Are you actually planning to add other fields in t
guoweis_left_chromium 2014/12/16 23:12:33 Yes, one other thing I'd like to track in the futu
54 struct P2PSendPacketMetrics {
55 P2PSendPacketMetrics() : packet_id(0) {}
56 explicit P2PSendPacketMetrics(uint64 packet_id) : packet_id(packet_id) {}
57
58 uint64 packet_id;
59 };
60
51 } // namespace content 61 } // namespace content
52 62
53 #endif // CONTENT_COMMON_P2P_SOCKET_TYPE_H_ 63 #endif // CONTENT_COMMON_P2P_SOCKET_TYPE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698