tools/metrics/histograms/histograms.xml - Issue 759923003: Detect situation when there is no missing send completion signal in P2PSocket implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 759923003: Detect situation when there is no missing send completion signal in P2PSocket implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 332d93c8755688078549034e4ec41dcb0eb06c7e..aded9bfa33e97ea15c699db5a25a4bb55426bc45 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -40191,6 +40191,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="WebRTC.ApplicationSocketMismatchPacketsDetected">

Alexei Svitkine (slow) 2014/12/09 20:22:55 Please specify an enum="" tag here. It sounds like

guoweis_left_chromium 2014/12/09 23:54:45 Done.

+ <owner>guoweis@chromium.org</owner>

+ <summary>

+ This counter detects the condition when a packet is sent from the

+ application layer down to the system but has never received the completion

+ signal for that packet to increment the send_bytes_available.

+ </summary>

+</histogram>

Removed from code 2014/2/25.

@@ -57802,6 +57811,7 @@ To add a new entry, add it with any value and run test to compute valid value.

<histogram_suffixes name="IPProtocolType" separator="_">

+ <affected-histogram name="WebRTC.ApplicationSocketMismatchPacketsDetected"/>

<affected-histogram name="WebRTC.SystemMaxConsecutiveBytesDelayed"/>

<affected-histogram name="WebRTC.SystemPercentPacketsDelayed"/>

<affected-histogram name="WebRTC.SystemSendPacketDuration"/>

« content/renderer/p2p/ipc_socket_factory.cc ('K') | « content/renderer/p2p/socket_dispatcher.cc ('k') | no next file » | no next file with comments »