Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: win8/test/metro_registration_helper.cc

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chrome build Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « win8/delegate_execute/chrome_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win8/test/metro_registration_helper.cc
diff --git a/win8/test/metro_registration_helper.cc b/win8/test/metro_registration_helper.cc
index c5d6735a4e9c831e5fdc9d91a1888dfd0bf41bf2..59b2235034c1dac80b2e43763665ad6551c3258f 100644
--- a/win8/test/metro_registration_helper.cc
+++ b/win8/test/metro_registration_helper.cc
@@ -53,13 +53,13 @@ bool RegisterTestDefaultBrowser() {
CommandLine register_command(registrar);
register_command.AppendArg("/RegServer");
- base::win::ScopedHandle register_handle;
- if (base::LaunchProcess(register_command.GetCommandLineString(),
- base::LaunchOptions(),
- &register_handle)) {
+ base::Process register_process =
+ base::LaunchProcess(register_command.GetCommandLineString(),
+ base::LaunchOptions());
+ if (register_process.IsValid()) {
int ret = 0;
if (base::WaitForExitCodeWithTimeout(
- register_handle.Get(), &ret,
+ register_process.Handle(), &ret,
base::TimeDelta::FromSeconds(kRegistrationTimeoutSeconds))) {
if (ret == 0) {
return true;
« no previous file with comments | « win8/delegate_execute/chrome_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698