content/browser/child_process_launcher.cc - Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_launcher.cc

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chrome build Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/child_process_launcher.cc

diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc

index 0870e6c2d1b2b07d1548a1415acbb0715ae1079e..636fd88fd0354f7bb64adeee0e2794301ed37e90 100644

--- a/content/browser/child_process_launcher.cc

+++ b/content/browser/child_process_launcher.cc

@@ -531,7 +531,7 @@ void ChildProcessLauncher::Context::TerminateInternal(

ZygoteHostImpl::GetInstance()->EnsureProcessTerminated(process.Handle());

} else

#endif // !OS_MACOSX

- base::EnsureProcessTerminated(process.Handle());

+ base::EnsureProcessTerminated(process.Pass());

#endif // OS_POSIX

#endif // defined(OS_ANDROID)

}

« no previous file with comments | « components/storage_monitor/storage_monitor_linux.cc ('k') | content/zygote/zygote_linux.cc » ('j') | no next file with comments »