base/process/launch.h - Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/launch.h

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chrome build Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process/launch.h

diff --git a/base/process/launch.h b/base/process/launch.h

index 06abb297965f4a43822de21f22b25415e8518262..0450ddf021e0faa7936bf7118951d050e185251b 100644

--- a/base/process/launch.h

+++ b/base/process/launch.h

@@ -22,7 +22,6 @@

#include "base/posix/file_descriptor_shuffle.h"

#elif defined(OS_WIN)

#include <windows.h>

-#include "base/win/scoped_handle.h"

#endif

namespace base {

@@ -174,9 +173,8 @@ BASE_EXPORT bool LaunchProcess(const CommandLine& cmdline,

// Example (including literal quotes)

// cmdline = "c:\windows\explorer.exe" -foo "c:\bar\"

-BASE_EXPORT bool LaunchProcess(const string16& cmdline,

- const LaunchOptions& options,

- win::ScopedHandle* process_handle);

+BASE_EXPORT Process LaunchProcess(const string16& cmdline,

+ const LaunchOptions& options);

// Launches a process with elevated privileges. This does not behave exactly

// like LaunchProcess as it uses ShellExecuteEx instead of CreateProcess to

« no previous file with comments | « base/process/kill_win.cc ('k') | base/process/launch_win.cc » ('j') | no next file with comments »