Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2945)

Unified Diff: chrome/installer/util/install_util.cc

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/install_util.cc
diff --git a/chrome/installer/util/install_util.cc b/chrome/installer/util/install_util.cc
index 56cb9440367c34fcfc313d693d0d648582a28ef2..932a1b1209277f986a4d95111756ee41a47c0478 100644
--- a/chrome/installer/util/install_util.cc
+++ b/chrome/installer/util/install_util.cc
@@ -156,7 +156,9 @@ void InstallUtil::TriggerActiveSetupCommand() {
base::LaunchOptions launch_options;
if (base::win::IsMetroProcess())
launch_options.force_breakaway_from_job_ = true;
- if (!base::LaunchProcess(cmd.GetCommandLineString(), launch_options, NULL))
+ base::Process process =
+ base::LaunchProcess(cmd.GetCommandLineString(), launch_options);
+ if (!process.IsValid())
PLOG(ERROR) << cmd.GetCommandLineString();
}

Powered by Google App Engine
This is Rietveld 408576698