Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3984)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/gcapi/gcapi.cc

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/uninstall_view.cc ('k') | chrome/installer/test/alternate_version_generator.cc » ('j') | components/storage_monitor/storage_monitor_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/gcapi/gcapi.cc
diff --git a/chrome/installer/gcapi/gcapi.cc b/chrome/installer/gcapi/gcapi.cc
index ce03d857fd6aece4c2137ae06e82ed5754816150..f08d90f2340975e651800bb5776d6a311a86147b 100644
--- a/chrome/installer/gcapi/gcapi.cc
+++ b/chrome/installer/gcapi/gcapi.cc
@@ -519,8 +519,7 @@ BOOL __stdcall LaunchGoogleChrome() {
// Couldn't get Omaha's process launcher, Omaha may not be installed at
// system level. Try just running Chrome instead.
ret = base::LaunchProcess(chrome_command.GetCommandLineString(),
- base::LaunchOptions(),
- NULL);
+ base::LaunchOptions()).IsValid();
}
if (impersonation_success)
« no previous file with comments | « chrome/browser/ui/views/uninstall_view.cc ('k') | chrome/installer/test/alternate_version_generator.cc » ('j') | components/storage_monitor/storage_monitor_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698