[Android] Remove the workaround code of a platform bug.

[Android] Remove the workaround code of a platform bug.

From our UMA and operation feedbacks, we don't see such issue anymore.
(We notified the manufactor of the issue and likely they addressed it
in OTA). The cleanup restores native library name to libchrome.so
instead of libchrome.<VER>.so.

BUG=311644
Committed: https://crrev.com/d9201758ca9e6dc47e36026a4029dae5cc69e4c4
Cr-Commit-Position: refs/heads/master@{#305925}

[Feng Qian, 2014-11-25 21:32:06]

feng@chromium.org changed reviewers:
+ isherman@chromium.org, rmcilroy@chromium.org

[Feng Qian, 2014-11-25 21:32:06]

isherman@ for histograms.xml changes.
rmcilroy for the reset.

[Feng Qian, 2014-11-25 21:34:31]

feng@chromium.org changed reviewers:
+ cjhopman@chromium.org

[Ilya Sherman, 2014-11-25 22:07:09]

histograms.xml lgtm

[rmcilroy, 2014-11-26 11:55:53]

Yay - glad to see this workaround going away.  lgtm with a couple of comments. 

+petrcermak as FYI

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
(right):

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:131: *
  should delete the old workaround and fallback libraries or not.
nit - remove "workaround and"

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:257:
if (!fallbackWasUsed) {
nit - merge into if block above.

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
File
base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java
(right):

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java:51:
static final String LOAD_FROM_APK_FALLBACK_DIR = "fallback";
nit - could you make this "fallback-lib" instead

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java:68:
private static String getJniNameInApk(String libName) {
Looks like we can delete this too.

[petrcermak, 2014-11-26 17:41:09]

petrcermak@chromium.org changed reviewers:
+ petrcermak@chromium.org

[petrcermak, 2014-11-26 17:41:10]

LGTM, agree with rmcilroy's comments.

Petr

[cjhopman, 2014-11-26 21:48:56]

lgtm

https://codereview.chromium.org/759833002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/759833002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:11579: +    Deprecated as of 11/2014,
removed form code.
nit: s/form/from?

[Feng Qian, 2014-11-26 22:07:16]

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
(right):

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:131: *
  should delete the old workaround and fallback libraries or not.
On 2014/11/26 11:55:53, rmcilroy wrote:
> nit - remove "workaround and"

Acknowledged.

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
File
base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java
(right):

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java:51:
static final String LOAD_FROM_APK_FALLBACK_DIR = "fallback";
On 2014/11/26 11:55:53, rmcilroy wrote:
> nit - could you make this "fallback-lib" instead 
If there are clients already use 'fallback', we need extra steps to cleanup the
old fallback libs.
The benefit might be far less than the extra code complexity introduced.

We should add a UMA stats to track how many users are using fallback libraries.
If there is none, we are safe to rename.

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java:68:
private static String getJniNameInApk(String libName) {
On 2014/11/26 11:55:53, rmcilroy wrote:
> Looks like we can delete this too.

Done.

[Feng Qian, 2014-11-26 22:20:58]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-11-26 22:22:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/759833002/40001

[rmcilroy, 2014-11-26 23:05:53]

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
File
base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java
(right):

https://codereview.chromium.org/759833002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/LibraryLoaderHelper.java:51:
static final String LOAD_FROM_APK_FALLBACK_DIR = "fallback";
On 2014/11/26 22:07:16, Feng Qian wrote:
> On 2014/11/26 11:55:53, rmcilroy wrote:
> > nit - could you make this "fallback-lib" instead 
> If there are clients already use 'fallback', we need extra steps to cleanup
the
> old fallback libs.
> The benefit might be far less than the extra code complexity introduced.
> 
> We should add a UMA stats to track how many users are using fallback
libraries.
> If there is none, we are safe to rename.

We do have UMA (ChromiumAndroidLinker.LibraryLoadFromApkStatus) and no clients
are currently using the fallback, but I agree it's not worth adding code to deal
with this.

[commit-bot: I haz the power, 2014-11-27 00:27:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-27 00:29:37]

Patchset 3 (id:??) landed as
https://crrev.com/d9201758ca9e6dc47e36026a4029dae5cc69e4c4
Cr-Commit-Position: refs/heads/master@{#305925}