src/objects-debug.cc - Issue 759823006: Ensure double alignment when deserializing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 759823006: Ensure double alignment when deserializing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 0e670993e0d965f2624f6cff9b581bfe5bcacda8..e49b47cc5cfa8f20d3b68f838999b837c268f25b 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -47,6 +47,10 @@ void HeapObject::HeapObjectVerify() {

return;

}

+ // TODO(yangguo): Use this check once crbug/436911 has been fixed.

+ // DCHECK(!NeedsToEnsureDoubleAlignment() ||

+ // IsAligned(OffsetFrom(address()), kDoubleAlignment));

switch (instance_type) {

case SYMBOL_TYPE:

Symbol::cast(this)->SymbolVerify();

« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »