Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 759823002: Identity API: Use AccountTrackerService for account details (Closed)

Created:
6 years ago by Ken Rockot(use gerrit already)
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Identity API: Use AccountTrackerService for account details This changes the chrome.identity.getProfileUserInfo implementation to use the signin AccountTrackerService as its source of account details, rather than prefs which are unavailable on Chrome OS. BUG=430290 R=rogerta@chromium.org Committed: https://crrev.com/b374dfdb835f0b9537aff21be6da262feec1ea6a Cr-Commit-Position: refs/heads/master@{#305930}

Patch Set 1 #

Patch Set 2 : Update tests to sign in properly #

Patch Set 3 : Aaand update tests again to shut down properly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -71 lines) Patch
M chrome/browser/extensions/api/identity/identity_api.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 2 7 chunks +70 lines, -65 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Ken Rockot(use gerrit already)
Roger could you please take a look?
6 years ago (2014-11-25 20:50:23 UTC) #1
Roger Tawa OOO till Jul 10th
Lgtm Thanks for fixing email too. Can you run extensions using identity api in incognito ...
6 years ago (2014-11-26 12:32:20 UTC) #2
Ken Rockot(use gerrit already)
On 2014/11/26 12:32:20, Roger Tawa wrote: > Lgtm > > Thanks for fixing email too. ...
6 years ago (2014-11-26 17:51:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759823002/1
6 years ago (2014-11-26 18:01:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/2459)
6 years ago (2014-11-26 19:05:04 UTC) #7
Roger Tawa OOO till Jul 10th
The tests are failing because they set the prefs, but the code no longer uses ...
6 years ago (2014-11-26 19:22:31 UTC) #8
Ken Rockot(use gerrit already)
On 2014/11/26 19:22:31, Roger Tawa wrote: > The tests are failing because they set the ...
6 years ago (2014-11-26 19:27:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759823002/20001
6 years ago (2014-11-26 22:45:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759823002/40001
6 years ago (2014-11-27 00:18:08 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-11-27 01:08:27 UTC) #15
commit-bot: I haz the power
6 years ago (2014-11-27 01:09:17 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b374dfdb835f0b9537aff21be6da262feec1ea6a
Cr-Commit-Position: refs/heads/master@{#305930}

Powered by Google App Engine
This is Rietveld 408576698