Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 759753005: cc: Enable GL_RED_EXT for YUV resources (Closed)

Created:
6 years ago by hendrikw
Modified:
6 years ago
Reviewers:
danakj, reveman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ext_texture_rg2
Project:
chromium
Visibility:
Public.

Description

cc: Enable GL_RED_EXT for YUV resources Exposed RED_8 as the yuv resource format via the resource provider, if available, and started using it for video BUG=435379 Committed: https://crrev.com/7bb78f185b01ee0b02d306d77c268b05d07a9fef Cr-Commit-Position: refs/heads/master@{#306510}

Patch Set 1 #

Patch Set 2 : Enable GL_RED_EXT for YUV #

Total comments: 1

Patch Set 3 : Restore correct name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M cc/resources/resource_provider.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 2 5 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hendrikw
PTAL
6 years ago (2014-12-02 15:49:07 UTC) #2
danakj
LGTM w/ 1 quibble https://codereview.chromium.org/759753005/diff/20001/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/759753005/diff/20001/cc/resources/video_resource_updater.cc#newcode135 cc/resources/video_resource_updater.cc:135: static gfx::Size PlaneDimension( leave this ...
6 years ago (2014-12-02 17:03:20 UTC) #4
hendrikw
On 2014/12/02 17:03:20, danakj wrote: > LGTM w/ 1 quibble > > https://codereview.chromium.org/759753005/diff/20001/cc/resources/video_resource_updater.cc > File ...
6 years ago (2014-12-02 17:08:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759753005/40001
6 years ago (2014-12-02 23:49:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-03 00:57:06 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-03 00:57:50 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7bb78f185b01ee0b02d306d77c268b05d07a9fef
Cr-Commit-Position: refs/heads/master@{#306510}

Powered by Google App Engine
This is Rietveld 408576698