Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: components/onc/docs/onc_spec.html

Issue 759663004: ONC: add support for non-utf-8 SSIDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed issues Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/test/data/network/toplevel_wifi_ssid_and_hexssid.onc ('k') | components/onc/onc_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/onc/docs/onc_spec.html
diff --git a/components/onc/docs/onc_spec.html b/components/onc/docs/onc_spec.html
index f4e70c808c956715b81a6564d755b8b156681511..a5e27ebf91eb18168354db28fd14bc6d0325f298 100644
--- a/components/onc/docs/onc_spec.html
+++ b/components/onc/docs/onc_spec.html
@@ -669,6 +669,21 @@
EAP settings.
</dd>
+ <dt class="field">HexSSID</dt>
+ <dd>
+ <span class="field_meta">
+ (optional if <span class="field">SSID</span> is set, if so defaults to
+ a hex representation of <span class="field">SSID</span>)
+ <span class="type">string</span>
+ </span>
+ Hex representation of the network's SSID. If the
+ <span class="field">SSID</span> field is set, but
+ <span class="field">HexSSID</span> is not, converts the contents of the
+ <span class="field">SSID</span> field to UTF-8 encoding,
+ creates the hex representation and assigns the result to
+ <span class="field">HexSSID</span>.
+ </dd>
+
<dt class="field">HiddenSSID</dt>
<dd>
<span class="field_meta">
@@ -711,10 +726,12 @@
<dt class="field">SSID</dt>
<dd>
<span class="field_meta">
- (required)
+ (optional if <span class="field">HexSSID</span> is set)
<span class="type">string</span>
</span>
- SSID of the network.
+ SSID of the network. This field can only used for unicode strings in the
+ UTF-8 encoding. For non-UTF-8 encodings the
+ <span class="field">HexSSID</span> field must be used.
</dd>
<dt class="field">SignalStrength</dt>
@@ -728,6 +745,14 @@
be set to '0' or not present.
</dd>
</dl>
+ <span class="rule">
+ <span class="rule_id"></span>
+ At least one of the fields <span class="field">HexSSID</span> or
+ <span class="field">SSID</span> must be present. If both
+ <span class="field">HexSSID</span> and <span class="field">SSID</span>
+ are set, the values must be consistent.
+ </span>
+ </span>
</section>
<section>
« no previous file with comments | « chromeos/test/data/network/toplevel_wifi_ssid_and_hexssid.onc ('k') | components/onc/onc_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698