chromeos/network/onc/onc_validator_unittest.cc - Issue 759663004: ONC: add support for non-utf-8 SSIDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_validator_unittest.cc

Issue 759663004: ONC: add support for non-utf-8 SSIDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed issues Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_validator_unittest.cc

diff --git a/chromeos/network/onc/onc_validator_unittest.cc b/chromeos/network/onc/onc_validator_unittest.cc

index c109ddc809bd754defccf2b96ae33e5642b78146..4daa6a6f0d9f90f0a7e2469f9340027c025f0671 100644

--- a/chromeos/network/onc/onc_validator_unittest.cc

+++ b/chromeos/network/onc/onc_validator_unittest.cc

@@ -152,6 +152,12 @@ INSTANTIATE_TEST_CASE_P(

OncParams("managed_toplevel_l2tpipsec.onc",

&kToplevelConfigurationSignature,

true),

+ OncParams("toplevel_wifi_hexssid.onc",

+ &kToplevelConfigurationSignature,

+ false),

+ OncParams("toplevel_wifi_ssid_and_hexssid.onc",

+ &kToplevelConfigurationSignature,

+ false),

OncParams("toplevel_wifi_wpa_psk.onc",

&kToplevelConfigurationSignature,

false),

@@ -449,6 +455,18 @@ INSTANTIATE_TEST_CASE_P(

&kNetworkConfigurationSignature,

false),

ExpectBothNotValid("", "")),

+ std::make_pair(OncParams("network-wifi-hexssid-invalid-length",

+ &kNetworkConfigurationSignature,

+ false),

+ ExpectBothNotValid("", "")),

+ std::make_pair(OncParams("network-wifi-invalid-hexssid",

+ &kNetworkConfigurationSignature,

+ false),

+ ExpectBothNotValid("", "")),

+ std::make_pair(OncParams("network-wifi-ssid-and-hexssid-inconsistent",

+ &kNetworkConfigurationSignature,

+ false),

+ ExpectBothNotValid("", "")),

std::make_pair(OncParams("managed-network-unknown-value",

&kNetworkConfigurationSignature,

true),