Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: sky/engine/core/dom/shadow/ShadowRoot.h

Issue 759663003: Only allow one shadowRoot. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: ojan review. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/shadow/InsertionPoint.h ('k') | sky/engine/core/dom/shadow/ShadowRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/shadow/ShadowRoot.h
diff --git a/sky/engine/core/dom/shadow/ShadowRoot.h b/sky/engine/core/dom/shadow/ShadowRoot.h
index 2fc9907b3b62d8c281cb84b888e1468a7b5276ad..e263f28db576d1827f65b7b96bde051d844f9471 100644
--- a/sky/engine/core/dom/shadow/ShadowRoot.h
+++ b/sky/engine/core/dom/shadow/ShadowRoot.h
@@ -31,7 +31,6 @@
#include "sky/engine/core/dom/DocumentFragment.h"
#include "sky/engine/core/dom/Element.h"
#include "sky/engine/core/dom/TreeScope.h"
-#include "sky/engine/wtf/DoublyLinkedList.h"
namespace blink {
@@ -42,9 +41,8 @@ class InsertionPoint;
class ShadowRootRareData;
class StyleSheetList;
-class ShadowRoot final : public DocumentFragment, public TreeScope, public DoublyLinkedListNode<ShadowRoot> {
+class ShadowRoot final : public DocumentFragment, public TreeScope {
DEFINE_WRAPPERTYPEINFO();
- friend class WTF::DoublyLinkedListNode<ShadowRoot>;
public:
static PassRefPtr<ShadowRoot> create(Document& document)
@@ -61,12 +59,6 @@ public:
Element* host() const { return toElement(parentOrShadowHostNode()); }
ElementShadow* owner() const { return host() ? host()->shadow() : 0; }
- ShadowRoot* youngerShadowRoot() const { return prev(); }
-
- bool isYoungest() const { return !youngerShadowRoot(); }
- bool isOldest() const { return !olderShadowRoot(); }
- bool isOldestAuthorShadowRoot() const;
-
virtual void insertedInto(ContainerNode*) override;
virtual void removedFrom(ContainerNode*) override;
@@ -92,8 +84,6 @@ public:
public:
Element* activeElement() const;
- ShadowRoot* olderShadowRoot() const { return next(); }
-
PassRefPtr<Node> cloneNode(bool, ExceptionState&);
PassRefPtr<Node> cloneNode(ExceptionState& exceptionState) { return cloneNode(true, exceptionState); }
@@ -116,11 +106,6 @@ private:
// ShadowRoots should never be cloned.
virtual PassRefPtr<Node> cloneNode(bool) override { return nullptr; }
- // FIXME: This shouldn't happen. https://bugs.webkit.org/show_bug.cgi?id=88834
- bool isOrphan() const { return !host(); }
-
- RawPtr<ShadowRoot> m_prev;
- RawPtr<ShadowRoot> m_next;
OwnPtr<ShadowRootRareData> m_shadowRootRareData;
unsigned m_numberOfStyles : 27;
unsigned m_registeredWithParentShadowRoot : 1;
« no previous file with comments | « sky/engine/core/dom/shadow/InsertionPoint.h ('k') | sky/engine/core/dom/shadow/ShadowRoot.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698