Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: sky/engine/bindings/core/v8/V8GCController.cpp

Issue 759663003: Only allow one shadowRoot. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: ojan review. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/benchmarks/dom/creation.sky ('k') | sky/engine/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/V8GCController.cpp
diff --git a/sky/engine/bindings/core/v8/V8GCController.cpp b/sky/engine/bindings/core/v8/V8GCController.cpp
index 606d98d440a81832213a2871429085ef3b9f9521..2f5df8ea1c59109c469be90cd988fbf85d09323c 100644
--- a/sky/engine/bindings/core/v8/V8GCController.cpp
+++ b/sky/engine/bindings/core/v8/V8GCController.cpp
@@ -171,14 +171,9 @@ private:
node->clearV8CollectableDuringMinorGC();
partiallyDependentNodes->append(node);
}
- if (ShadowRoot* shadowRoot = node->youngestShadowRoot()) {
+ if (ShadowRoot* shadowRoot = node->shadowRoot()) {
if (!traverseTree(shadowRoot, partiallyDependentNodes))
return false;
- } else if (node->isShadowRoot()) {
- if (ShadowRoot* shadowRoot = toShadowRoot(node)->olderShadowRoot()) {
- if (!traverseTree(shadowRoot, partiallyDependentNodes))
- return false;
- }
}
// <template> has a |content| property holding a DOM fragment which we must traverse,
// just like we do for the shadow trees above.
« no previous file with comments | « sky/benchmarks/dom/creation.sky ('k') | sky/engine/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698