Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 759663003: Only allow one shadowRoot. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
abarth-chromium, ojan
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : ojan review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -205 lines) Patch
M sky/benchmarks/dom/creation.sky View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8GCController.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/ContainerNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Element.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Node.cpp View 8 chunks +8 lines, -34 lines 0 comments Download
M sky/engine/core/dom/TreeScope.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/TreeScope.cpp View 4 chunks +3 lines, -16 lines 0 comments Download
M sky/engine/core/dom/TreeScopeAdopter.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M sky/engine/core/dom/TreeScopeTest.cpp View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M sky/engine/core/dom/shadow/ComposedTreeWalker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/shadow/ComposedTreeWalker.cpp View 3 chunks +1 line, -11 lines 0 comments Download
M sky/engine/core/dom/shadow/ElementShadow.h View 1 2 4 chunks +5 lines, -24 lines 0 comments Download
M sky/engine/core/dom/shadow/ElementShadow.cpp View 1 2 7 chunks +24 lines, -29 lines 0 comments Download
M sky/engine/core/dom/shadow/InsertionPoint.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.h View 5 chunks +1 line, -16 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 5 chunks +3 lines, -12 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/TextIterator.cpp View 1 chunk +5 lines, -16 lines 0 comments Download
M sky/engine/core/events/EventPath.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/tests/data/touch-action-tests.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/sky-element/sky-element.sky View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/dom/appendChild.sky View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/dom/replaceChild.sky View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/mutation-observer/shadow-dom.sky View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
esprehn
6 years ago (2014-11-26 17:36:47 UTC) #2
ojan
lgtm https://codereview.chromium.org/759663003/diff/20001/sky/engine/core/dom/Element.cpp File sky/engine/core/dom/Element.cpp (right): https://codereview.chromium.org/759663003/diff/20001/sky/engine/core/dom/Element.cpp#newcode1052 sky/engine/core/dom/Element.cpp:1052: PassRefPtr<ShadowRoot> Element::createShadowRoot(ExceptionState& exceptionState) s/createShadowRoot/ensureShadowRoot ? https://codereview.chromium.org/759663003/diff/20001/sky/engine/core/dom/shadow/ElementShadow.cpp File sky/engine/core/dom/shadow/ElementShadow.cpp ...
6 years ago (2014-11-26 18:43:17 UTC) #3
esprehn
Committed patchset #3 (id:40001) manually as 8dd1c4fdefb528625165b5c4611e00503e1d4074.
6 years ago (2014-11-26 18:54:18 UTC) #4
esprehn
6 years ago (2014-11-26 18:54:23 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/759663003/diff/20001/sky/engine/core/dom/Elem...
File sky/engine/core/dom/Element.cpp (right):

https://codereview.chromium.org/759663003/diff/20001/sky/engine/core/dom/Elem...
sky/engine/core/dom/Element.cpp:1052: PassRefPtr<ShadowRoot>
Element::createShadowRoot(ExceptionState& exceptionState)
On 2014/11/26 at 18:43:17, ojan wrote:
> s/createShadowRoot/ensureShadowRoot ?

done.

https://codereview.chromium.org/759663003/diff/20001/sky/engine/core/dom/shad...
File sky/engine/core/dom/shadow/ElementShadow.cpp (right):

https://codereview.chromium.org/759663003/diff/20001/sky/engine/core/dom/shad...
sky/engine/core/dom/shadow/ElementShadow.cpp:164: void
ElementShadow::removeDetachedShadowRoots()
On 2014/11/26 at 18:43:17, ojan wrote:
> removedDetachedShadowRoot ?

done.

Powered by Google App Engine
This is Rietveld 408576698