Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 759653004: Update invariant output computation for various texture effects. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update invariant output computation for various texture effects. Update various effects that read in textures to check whether or not the texture is alpha only. This allows us to use a more specific mulByUnKnownAlpha instead of the more general mulByUnknownColor BUG=skia: Committed: https://skia.googlesource.com/skia/+/f8449babdc430bb522c0eb87ce18f05c54d83714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
egdaniel
This improvement is needed so that when I land my XP work I can correctly ...
6 years ago (2014-11-25 17:04:41 UTC) #2
jvanverth1
lgtm
6 years ago (2014-11-25 18:13:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759653004/1
6 years ago (2014-11-25 18:15:20 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-25 18:25:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f8449babdc430bb522c0eb87ce18f05c54d83714

Powered by Google App Engine
This is Rietveld 408576698