Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 75963006: Use proportional line height for menu items to prevent clipping. (Closed)

Created:
7 years, 1 month ago by ljs
Modified:
7 years, 1 month ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use proportional line height for menu items to prevent clipping. BUG=305913 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236421

Patch Set 1 #

Total comments: 1

Patch Set 2 : em equivalent of 17px. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/uber/uber_frame.css View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ljs
A proposed simple fix to 305913. PTAL.
7 years, 1 month ago (2013-11-20 00:13:56 UTC) #1
Dan Beam
good idea; very close. https://codereview.chromium.org/75963006/diff/1/chrome/browser/resources/uber/uber_frame.css File chrome/browser/resources/uber/uber_frame.css (right): https://codereview.chromium.org/75963006/diff/1/chrome/browser/resources/uber/uber_frame.css#newcode54 chrome/browser/resources/uber/uber_frame.css:54: line-height: 1.45em; line-height: 1.417em; /* ...
7 years, 1 month ago (2013-11-20 07:21:35 UTC) #2
ljs
On 2013/11/20 07:21:35, Dan Beam wrote: > good idea; very close. > > https://codereview.chromium.org/75963006/diff/1/chrome/browser/resources/uber/uber_frame.css > ...
7 years, 1 month ago (2013-11-20 12:01:23 UTC) #3
Dan Beam
lgtm
7 years, 1 month ago (2013-11-20 22:16:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lstoakes@gmail.com/75963006/60001
7 years, 1 month ago (2013-11-20 22:28:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lstoakes@gmail.com/75963006/60001
7 years, 1 month ago (2013-11-21 01:59:56 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 06:43:07 UTC) #7
Message was sent while issue was closed.
Change committed as 236421

Powered by Google App Engine
This is Rietveld 408576698