chrome/browser/bookmarks/bookmark_utils_unittest.cc - Issue 75963003: Include folders in bookmark search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_utils_unittest.cc

Issue 75963003: Include folders in bookmark search (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change behavior for GetBookmarksContainingText Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bookmarks/bookmark_utils_unittest.cc

diff --git a/chrome/browser/bookmarks/bookmark_utils_unittest.cc b/chrome/browser/bookmarks/bookmark_utils_unittest.cc

index 9e5396b1faeedc92e10a0c36767470481bc45b35..90ed7f8a07edf767df5262964b54633334f7b1a8 100644

--- a/chrome/browser/bookmarks/bookmark_utils_unittest.cc

+++ b/chrome/browser/bookmarks/bookmark_utils_unittest.cc

@@ -38,13 +38,16 @@ TEST_F(BookmarkUtilsTest, GetBookmarksContainingText) {

ASCIIToUTF16("baz buz"),

GURL("http://www.cnn.com"));

- model.AddFolder(model.other_node(), 0, ASCIIToUTF16("foo"));

+ const BookmarkNode* n3 = model.AddFolder(model.other_node(),

tfarina 2013/11/21 23:00:16 I'd name this folder1, or even just folder.

+ 0,

+ ASCIIToUTF16("foo"));

std::vector<const BookmarkNode*> nodes;

GetBookmarksContainingText(

&model, ASCIIToUTF16("foo"), 100, string(), &nodes);

- ASSERT_EQ(1U, nodes.size());

- EXPECT_TRUE(nodes[0] == n1);

+ ASSERT_EQ(2U, nodes.size());

+ EXPECT_TRUE(nodes[0] == n3);

+ EXPECT_TRUE(nodes[1] == n1);

nodes.clear();

GetBookmarksContainingText(

« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.cc ('k') | no next file » | no next file with comments »