Include folders in bookmark search

Include folders in bookmarks search.

Folders are now returned in bookmark searches, and double clicking a folder from
the results will allow the user to navigate the folder's contents.

BUG=17306
TEST=unit_tests --gtest_filter=BookmarkUtilsTest.GetBookmarksContainingText
R=mpcomplete,sky,tfarina

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237497

[d.halman, 2013-11-19 17:38:52]

mpcomplete@chromium.org: Please review changes in 
c/b/extensions

brettw@chromium.org: Please review changes in 
c/b/bookmarks

[Matt Perry, 2013-11-19 19:46:42]

lgtm

[tfarina, 2013-11-19 21:38:12]

not lgtm (yet).

less brett.

+Scott for review.

bookmarks_api.cc is the solo caller of GetBookmarksContainingText(). Why don't
remove the is_url() check from it?

Also, there are existing unit tests for this function, if you are changing it to
search for folders too, please add unit tests to cover that case too.

[d.halman, 2013-11-21 20:52:03]

Made the changes requested by tfarina, updated the test case to match new
expected behavior.

[tfarina, 2013-11-21 23:00:16]

Other than the name issue below, I'm fine with this. Thanks for making the
minimal necessary changes, much clearer!

I leave to Scott for the final approval.

https://codereview.chromium.org/75963003/diff/60001/chrome/browser/bookmarks/...
File chrome/browser/bookmarks/bookmark_utils_unittest.cc (right):

https://codereview.chromium.org/75963003/diff/60001/chrome/browser/bookmarks/...
chrome/browser/bookmarks/bookmark_utils_unittest.cc:41: const BookmarkNode* n3 =
model.AddFolder(model.other_node(),
I'd name this folder1, or even just folder.

[sky, 2013-11-21 23:32:28]

LGTM

[tfarina, 2013-11-22 23:26:00]

I put this on CQ!

[commit-bot: I haz the power, 2013-11-22 23:27:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/d.halman@gmail.com/75963003/60001

[commit-bot: I haz the power, 2013-11-23 01:33:24]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[tfarina, 2013-11-23 01:50:23]

The test failures are real.

You need to fix ExtensionApiTest.Bookmarks too.

[d.halman, 2013-11-26 00:12:44]

Modified bookmarks/test.js to expect the change in behavior. Ran the bookmark
browser tests locally to ensure it fixed the issue it was encountering in patch
set 2. Also improved the variable names in bookmark_utils_unittest.cc as
requested.

[tfarina, 2013-11-26 22:34:56]

lgtm

[commit-bot: I haz the power, 2013-11-26 22:36:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/d.halman@gmail.com/75963003/460001

[commit-bot: I haz the power, 2013-11-27 03:49:46]

Change committed as 237497