Optimize highQualityFilter

src/opts/SkBitmapFilter_opts_SSE2.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <emmintrin.h>
 #include "SkBitmap.h"
 #include "SkBitmapFilter_opts_SSE2.h"
@@ skipping 31 matching lines @@
 
 // because the border is handled specially, this is guaranteed to have all 16 pixels
 // available to it without running off the bitmap's edge.
 
 void highQualityFilter_SSE2(const SkBitmapProcState& s, int x, int y,
                             SkPMColor* SK_RESTRICT colors, int count) {
 
     const int maxX = s.fBitmap->width();
     const int maxY = s.fBitmap->height();
     SkAutoTMalloc<SkScalar> xWeights(maxX);
+    const SkBitmapFilter* filter = s.getBitmapFilter();
 
     while (count-- > 0) {
         SkPoint srcPt;
         s.fInvProc(s.fInvMatrix, x + 0.5f, y + 0.5f, &srcPt);
         srcPt.fX -= SK_ScalarHalf;
         srcPt.fY -= SK_ScalarHalf;
 
         __m128 weight = _mm_setzero_ps();
         __m128 accum = _mm_setzero_ps();
 
-        int y0 = SkClampMax(SkScalarCeilToInt(srcPt.fY-s.getBitmapFilter()->width()), maxY);
-        int y1 = SkClampMax(SkScalarFloorToInt(srcPt.fY+s.getBitmapFilter()->width()+1), maxY);
-        int x0 = SkClampMax(SkScalarCeilToInt(srcPt.fX-s.getBitmapFilter()->width()), maxX);
-        int x1 = SkClampMax(SkScalarFloorToInt(srcPt.fX+s.getBitmapFilter()->width())+1, maxX);
+        int y0 = SkClampMax(SkScalarCeilToInt(srcPt.fY - filter->width()), maxY);
+        int y1 = SkClampMax(SkScalarFloorToInt(srcPt.fY + filter->width() + 1), maxY);
+        int x0 = SkClampMax(SkScalarCeilToInt(srcPt.fX - filter->width()), maxX);
+        int x1 = SkClampMax(SkScalarFloorToInt(srcPt.fX + filter->width()) + 1, maxX);
 
         for (int srcX = x0; srcX < x1 ; srcX++) {
             // Looking these up once instead of each loop is a ~15% speedup.
-            xWeights[srcX - x0] = s.getBitmapFilter()->lookupScalar((srcPt.fX - srcX));
+            xWeights[srcX - x0] = filter->lookupScalar((srcPt.fX - srcX));
         }
 
         for (int srcY = y0; srcY < y1; srcY++) {
-            SkScalar yWeight = s.getBitmapFilter()->lookupScalar((srcPt.fY - srcY));
+            SkScalar yWeight = filter->lookupScalar((srcPt.fY - srcY));
 
             for (int srcX = x0; srcX < x1 ; srcX++) {
                 SkScalar xWeight = xWeights[srcX - x0];
 
                 SkScalar combined_weight = SkScalarMul(xWeight, yWeight);
+                __m128 weightVector = _mm_set1_ps(combined_weight);
+                weight = _mm_add_ps( weight, weightVector );
 
                 SkPMColor color = *s.fBitmap->getAddr32(srcX, srcY);
+                if (!color) {
+                    continue;
+                }
 
                 __m128i c = _mm_cvtsi32_si128(color);
                 c = _mm_unpacklo_epi8(c, _mm_setzero_si128());
                 c = _mm_unpacklo_epi16(c, _mm_setzero_si128());
                 __m128 cfloat = _mm_cvtepi32_ps(c);
 
-                __m128 weightVector = _mm_set1_ps(combined_weight);
                 accum = _mm_add_ps(accum, _mm_mul_ps(cfloat, weightVector));
-                weight = _mm_add_ps( weight, weightVector );
             }
         }
 
         accum = _mm_div_ps(accum, weight);
         accum = _mm_add_ps(accum, _mm_set1_ps(0.5f));
         __m128i accumInt = _mm_cvttps_epi32(accum);
         accumInt = _mm_packs_epi32(accumInt, _mm_setzero_si128());
         accumInt = _mm_packus_epi16(accumInt, _mm_setzero_si128());
         SkPMColor c = _mm_cvtsi128_si32(accumInt);
 
@@ skipping 453 matching lines @@
 void applySIMDPadding_SSE2(SkConvolutionFilter1D *filter) {
     // Padding |paddingCount| of more dummy coefficients after the coefficients
     // of last filter to prevent SIMD instructions which load 8 or 16 bytes
     // together to access invalid memory areas. We are not trying to align the
     // coefficients right now due to the opaqueness of <vector> implementation.
     // This has to be done after all |AddFilter| calls.
     for (int i = 0; i < 8; ++i) {
         filter->addFilterValue(static_cast<SkConvolutionFilter1D::ConvolutionFixed>(0));
     }
 }