Set the internal format of hardware decoded texture to GL_RGBA.

Set the internal format of hardware decoded texture to GL_RGBA.

0 is not a valid internal format. DoCopyTextureCHROMIUM returns
failure if the source internal format is 0.

BUG=chromeos-partner:33193
TEST=Try Hangout capture on pit. Run apprtc loopback. Play Youtube.
Run VDA unittest.

Committed: https://crrev.com/89de3fbd8822cda4eb68882275cc46680ed13fbb
Cr-Commit-Position: refs/heads/master@{#305962}

[wuchengli, 2014-11-25 08:50:00]

wuchengli@chromium.org changed reviewers:
+ piman@chromium.org, posciak@chromium.org, reveman@chromium.org

[wuchengli, 2014-11-25 08:50:07]

PTAL.

[reveman, 2014-11-25 14:02:44]

lgtm

[piman, 2014-11-25 18:06:50]

lgtm

[wuchengli, 2014-11-26 08:54:08]

On 2014/11/25 18:06:50, piman (Very slow to review) wrote:
> lgtm

Sorry. I just realized SetLevelInfo has another parameter |format|. What is the
difference between |internal_format| and |format|? I searched through the code
and most just set them to the same -- GL_RGBA. In my understanding, |format| is
the format of the texel data. But SetLevelInfo doesn't have data parameter.

[wuchengli, 2014-11-26 11:50:28]

On 2014/11/26 08:54:08, wuchengli wrote:
> On 2014/11/25 18:06:50, piman (Very slow to review) wrote:
> > lgtm
> 
> Sorry. I just realized SetLevelInfo has another parameter |format|. What is
the
> difference between |internal_format| and |format|? I searched through the code
> and most just set them to the same -- GL_RGBA. In my understanding, |format|
is
> the format of the texel data. But SetLevelInfo doesn't have data parameter.
I also set format to GL_RGBA. That's what most code that calls SetLevelInfo
does.

[reveman, 2014-11-26 16:47:01]

On 2014/11/26 08:54:08, wuchengli wrote:
> On 2014/11/25 18:06:50, piman (Very slow to review) wrote:
> > lgtm
> 
> Sorry. I just realized SetLevelInfo has another parameter |format|. What is
the
> difference between |internal_format| and |format|? I searched through the code
> and most just set them to the same -- GL_RGBA. In my understanding, |format|
is
> the format of the texel data. But SetLevelInfo doesn't have data parameter.

Yes, |format| is the format of the data provided to ie. glTexImage2D. I don't
think it matters in this case. Still lgtm.

[piman, 2014-11-26 19:54:08]

On Wed, Nov 26, 2014 at 12:54 AM, <wuchengli@chromium.org> wrote:

> On 2014/11/25 18:06:50, piman (Very slow to review) wrote:
>
>> lgtm
>>
>
> Sorry. I just realized SetLevelInfo has another parameter |format|. What
> is the
> difference between |internal_format| and |format|? I searched through the
> code
> and most just set them to the same -- GL_RGBA.


In GLES2, they have to be the same.


> In my understanding, |format| is
> the format of the texel data. But SetLevelInfo doesn't have data parameter.
>
> https://codereview.chromium.org/759573002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[wuchengli, 2014-11-27 05:50:28]

The CQ bit was checked by wuchengli@chromium.org

[commit-bot: I haz the power, 2014-11-27 05:51:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/759573002/20001

[commit-bot: I haz the power, 2014-11-27 06:41:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-27 06:42:26]

Patchset 2 (id:??) landed as
https://crrev.com/89de3fbd8822cda4eb68882275cc46680ed13fbb
Cr-Commit-Position: refs/heads/master@{#305962}