Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 759573002: Set the internal format of hardware decoded texture to GL_RGBA. (Closed)

Created:
6 years ago by wuchengli
Modified:
6 years ago
Reviewers:
reveman, Pawel Osciak, piman
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set the internal format of hardware decoded texture to GL_RGBA. 0 is not a valid internal format. DoCopyTextureCHROMIUM returns failure if the source internal format is 0. BUG=chromeos-partner:33193 TEST=Try Hangout capture on pit. Run apprtc loopback. Play Youtube. Run VDA unittest. Committed: https://crrev.com/89de3fbd8822cda4eb68882275cc46680ed13fbb Cr-Commit-Position: refs/heads/master@{#305962}

Patch Set 1 #

Patch Set 2 : set format to GL_RGBA #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
wuchengli
PTAL.
6 years ago (2014-11-25 08:50:07 UTC) #2
reveman
lgtm
6 years ago (2014-11-25 14:02:44 UTC) #3
piman
lgtm
6 years ago (2014-11-25 18:06:50 UTC) #4
wuchengli
On 2014/11/25 18:06:50, piman (Very slow to review) wrote: > lgtm Sorry. I just realized ...
6 years ago (2014-11-26 08:54:08 UTC) #5
wuchengli
On 2014/11/26 08:54:08, wuchengli wrote: > On 2014/11/25 18:06:50, piman (Very slow to review) wrote: ...
6 years ago (2014-11-26 11:50:28 UTC) #6
reveman
On 2014/11/26 08:54:08, wuchengli wrote: > On 2014/11/25 18:06:50, piman (Very slow to review) wrote: ...
6 years ago (2014-11-26 16:47:01 UTC) #7
piman
On Wed, Nov 26, 2014 at 12:54 AM, <wuchengli@chromium.org> wrote: > On 2014/11/25 18:06:50, piman ...
6 years ago (2014-11-26 19:54:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759573002/20001
6 years ago (2014-11-27 05:51:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-27 06:41:34 UTC) #11
commit-bot: I haz the power
6 years ago (2014-11-27 06:42:26 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89de3fbd8822cda4eb68882275cc46680ed13fbb
Cr-Commit-Position: refs/heads/master@{#305962}

Powered by Google App Engine
This is Rietveld 408576698