Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Issue 759483003: Fix bug in city-list autoscroll (Closed)

Created:
6 years ago by rafaelw
Modified:
6 years ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sky/examples/city-list/index.sky View 2 chunks +1 line, -2 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
rafaelw
Committed patchset #1 (id:1) manually as 0815d480090be7d94964cabaaa99587bb232b9ce (presubmit successful).
6 years ago (2014-11-25 02:28:05 UTC) #2
abarth-chromium
lgtm
6 years ago (2014-11-25 02:34:56 UTC) #4
esprehn
https://codereview.chromium.org/759483003/diff/1/sky/examples/city-list/index.sky File sky/examples/city-list/index.sky (right): https://codereview.chromium.org/759483003/diff/1/sky/examples/city-list/index.sky#newcode34 sky/examples/city-list/index.sky:34: var scrollBy = Number(location.search.match(/auto=([0-9]+)/)[1]); match returns null if it ...
6 years ago (2014-11-25 07:50:21 UTC) #5
rafaelw
6 years ago (2014-11-28 04:22:49 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/759483003/diff/1/sky/examples/city-list/index...
File sky/examples/city-list/index.sky (right):

https://codereview.chromium.org/759483003/diff/1/sky/examples/city-list/index...
sky/examples/city-list/index.sky:34: var scrollBy =
Number(location.search.match(/auto=([0-9]+)/)[1]);
On 2014/11/25 07:50:21, esprehn wrote:
> match returns null if it doesn't match anything, this is going to throw an
> exception when you index into null.

Woops. Good catch. Fixed: https://codereview.chromium.org/760403002/

Powered by Google App Engine
This is Rietveld 408576698