Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: content/renderer/renderer_main_platform_delegate_android.cc

Issue 759403002: Add --enable-seccomp-filter-sandbox to about:flags on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_main_platform_delegate_android.cc
diff --git a/content/renderer/renderer_main_platform_delegate_android.cc b/content/renderer/renderer_main_platform_delegate_android.cc
index 3cafcca7151c5b7f1a4bcf54a14778505a0b85f0..de7616b010dbe591196437857768fc352dcc992d 100644
--- a/content/renderer/renderer_main_platform_delegate_android.cc
+++ b/content/renderer/renderer_main_platform_delegate_android.cc
@@ -35,6 +35,12 @@ bool RendererMainPlatformDelegate::EnableSandbox() {
switches::kEnableSeccompFilterSandbox)) {
return true;
}
+ if (!sandbox::SandboxBPF::SupportsSeccompSandbox(
jln (very slow on Chromium) 2014/11/26 22:29:55 This is especially problematic since we don't have
Robert Sesek 2014/11/26 22:32:25 Right, if about:flags weren't WebUI I wouldn't hav
no sievers 2014/11/26 23:35:11 Yea you'd have to go to Settings -> Apps and erase
+ sandbox::SandboxBPF::SeccompLevel::MULTI_THREADED)) {
+ LOG(WARNING) << "Seccomp-BPF sandbox enabled without kernel support. "
jln (very slow on Chromium) 2014/11/26 22:29:55 LOG(ERROR) at least?
+ << "Ignoring flag and proceeding without seccomp sandbox.";
+ return true;
+ }
sandbox::SandboxBPF sandbox;
sandbox.SetSandboxPolicy(new SandboxBPFBasePolicyAndroid());
« no previous file with comments | « content/content_renderer.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698