Source/core/rendering/style/RenderStyle.cpp - Issue 759373002: Better handling border color style decoration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 759373002: Better handling border color style decoration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changing the test per reviewer's request. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/style/RenderStyle.cpp

diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp

index 4aaf56bfab85abfe8fb4d4b841e8a9566d5dd275..8a44fe44f8448b4120053041f5601c4642993a77 100644

--- a/Source/core/rendering/style/RenderStyle.cpp

+++ b/Source/core/rendering/style/RenderStyle.cpp

@@ -1424,10 +1424,6 @@ Color RenderStyle::colorIncludingFallback(int colorProperty, bool visitedLink) c

if (!result.isCurrentColor())

return result.color();

- // FIXME: Treating styled borders with initial color differently causes problems

- // See crbug.com/316559, crbug.com/276231

- if (!visitedLink && (borderStyle == INSET || borderStyle == OUTSET || borderStyle == RIDGE || borderStyle == GROOVE))

- return Color(238, 238, 238);

return visitedLink ? visitedLinkColor() : color();

}