Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 759373002: Better handling border color style decoration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove unset border color in RenderStyle Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/paint/ObjectPainter.cpp ('K') | « Source/core/paint/ObjectPainter.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/RenderStyle.cpp
diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp
index 4aaf56bfab85abfe8fb4d4b841e8a9566d5dd275..8a44fe44f8448b4120053041f5601c4642993a77 100644
--- a/Source/core/rendering/style/RenderStyle.cpp
+++ b/Source/core/rendering/style/RenderStyle.cpp
@@ -1424,10 +1424,6 @@ Color RenderStyle::colorIncludingFallback(int colorProperty, bool visitedLink) c
if (!result.isCurrentColor())
return result.color();
- // FIXME: Treating styled borders with initial color differently causes problems
- // See crbug.com/316559, crbug.com/276231
- if (!visitedLink && (borderStyle == INSET || borderStyle == OUTSET || borderStyle == RIDGE || borderStyle == GROOVE))
- return Color(238, 238, 238);
return visitedLink ? visitedLinkColor() : color();
}
« Source/core/paint/ObjectPainter.cpp ('K') | « Source/core/paint/ObjectPainter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698