Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc

Issue 759343002: sandbox: sandbox_linux_unittests enforces TSYNC on ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc
diff --git a/sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc b/sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc
index 66669e796c69dbba717395c2a4772c96f5716aa3..1b58622a2fe3640cf7e3d9def57503ecb61148c4 100644
--- a/sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc
+++ b/sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc
@@ -2267,10 +2267,15 @@ void* TsyncApplyToTwoThreadsFunc(void* cond_ptr) {
}
SANDBOX_TEST(SandboxBPF, Tsync) {
- if (SandboxBPF::SupportsSeccompThreadFilterSynchronization() !=
- SandboxBPF::STATUS_AVAILABLE) {
+ SandboxBPF::SandboxStatus sandbox_status =
+ SandboxBPF::SupportsSeccompThreadFilterSynchronization();
jln (very slow on Chromium) 2014/11/26 22:22:33 This is a very outdated API, you should re-sync :)
+#if defined(OS_CHROMEOS)
jln (very slow on Chromium) 2014/11/26 22:22:33 This won't work unfortunately. OS_CHROMEOS is jus
+ BPF_ASSERT_EQ(SandboxBPF::STATUS_AVAILABLE, sandbox_status);
+#else
+ if (sandbox_status != SandboxBPF::STATUS_AVAILABLE) {
return;
}
+#endif
base::WaitableEvent event(true, false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698