sandbox: sandbox_linux_unittests enforces TSYNC on ChromeOS

sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/linux/bpf_dsl/bpf_dsl.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <pthread.h>
 #include <sched.h>
@@ skipping 12 matching lines @@
 #define __user
 #endif
 #include <linux/futex.h>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/synchronization/waitable_event.h"
+#include "base/sys_info.h"
 #include "base/threading/thread.h"
 #include "build/build_config.h"
 #include "sandbox/linux/bpf_dsl/policy.h"
 #include "sandbox/linux/seccomp-bpf/bpf_tests.h"
 #include "sandbox/linux/seccomp-bpf/die.h"
 #include "sandbox/linux/seccomp-bpf/errorcode.h"
 #include "sandbox/linux/seccomp-bpf/linux_seccomp.h"
 #include "sandbox/linux/seccomp-bpf/sandbox_bpf.h"
 #include "sandbox/linux/seccomp-bpf/syscall.h"
 #include "sandbox/linux/seccomp-bpf/trap.h"
@@ skipping 2203 matching lines @@
   }
 
   BPF_ASSERT(event->IsSignaled());
 
   BlacklistNanosleepPolicy::AssertNanosleepFails();
 
   return NULL;
 }
 
 SANDBOX_TEST(SandboxBPF, Tsync) {
-  if (!(SandboxBPF::SupportsSeccompSandbox(
-          SandboxBPF::SeccompLevel::MULTI_THREADED))) {
+  const bool supports_multi_threaded = SandboxBPF::SupportsSeccompSandbox(
+      SandboxBPF::SeccompLevel::MULTI_THREADED);
+// On ChromeOS tsync is mandatory.

[Jorge Lucangeli Obes, 2014/12/03 17:19:38]

Nit: "Chrome OS" with a space.

[leecam, 2014/12/03 17:25:23]

Done.

+#if defined(OS_CHROMEOS)
+  if (base::SysInfo::IsRunningOnChromeOS()) {
+    BPF_ASSERT_EQ(true, supports_multi_threaded);
+  }
+// else a ChromeOS build not running on a ChromeOS device e.g. chrome bots.

[Jorge Lucangeli Obes, 2014/12/03 17:19:38]

Same nit, and you probably want to capitalize Chrome.

[leecam, 2014/12/03 17:25:23]

Done.

+// In this case fall through.
+#endif
+  if (!supports_multi_threaded) {
     return;
   }
 
   base::WaitableEvent event(true, false);
 
   // Create a thread on which to invoke the blocked syscall.
   pthread_t thread;
   BPF_ASSERT_EQ(
       0, pthread_create(&thread, NULL, &TsyncApplyToTwoThreadsFunc, &event));
 
@@ skipping 109 matching lines @@
   BPF_ASSERT_EQ(ENOSYS, errno);
 
   BPF_ASSERT_EQ(-1, syscall(__NR_setgid, 300));
   BPF_ASSERT_EQ(EPERM, errno);
 }
 
 }  // namespace
 
 }  // namespace bpf_dsl
 }  // namespace sandbox