Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 75933002: IDL compiler: rename object => wrapper in toActiveDOMObject (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: rename object => wrapper in toActiveDOMObject Per haraken's request here: https://codereview.chromium.org/74783008/#msg2 BUG=239771 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObjectInterface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nils Barth (inactive)
7 years, 1 month ago (2013-11-19 01:45:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/75933002/1
7 years, 1 month ago (2013-11-19 01:45:50 UTC) #2
haraken
LGTM
7 years, 1 month ago (2013-11-19 03:27:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=15168
7 years, 1 month ago (2013-11-19 03:54:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/75933002/1
7 years, 1 month ago (2013-11-19 04:15:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=15198
7 years, 1 month ago (2013-11-19 06:15:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/75933002/1
7 years, 1 month ago (2013-11-19 06:37:50 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 08:24:16 UTC) #8
Message was sent while issue was closed. 
Change committed as 162280

Powered by Google App Engine
This is Rietveld 408576698