Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 759313002: Add to WindowsExitCode enum (Closed)

Created:
6 years ago by Sigurður Ásgeirsson
Modified:
6 years ago
Reviewers:
gab, Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org, erikwright (departed)
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Add defined content and chrome exit codes, as well as commonly seen Windows errors to the WindowsExitCode enum BUG=412384 Committed: https://crrev.com/f3feaa9c705b4a844ec37d52cb91c12e8c9e8dd9 Cr-Commit-Position: refs/heads/master@{#305870}

Patch Set 1 #

Patch Set 2 : Fix off-by-one. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +38 lines, -5 lines 1 comment Download

Messages

Total messages: 11 (3 generated)
Sigurður Ásgeirsson
PTAL
6 years ago (2014-11-26 16:55:55 UTC) #2
Sigurður Ásgeirsson
Ooops, hold off a little - I goofed in the content codes..
6 years ago (2014-11-26 16:57:48 UTC) #3
Sigurður Ásgeirsson
On 2014/11/26 16:57:48, Sigurður Ásgeirsson wrote: > Ooops, hold off a little - I goofed ...
6 years ago (2014-11-26 17:05:22 UTC) #4
Mark P
rubber stamp lgtm (I assume those code are right.) --mark
6 years ago (2014-11-26 19:10:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759313002/20001
6 years ago (2014-11-26 19:11:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-26 20:31:28 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f3feaa9c705b4a844ec37d52cb91c12e8c9e8dd9 Cr-Commit-Position: refs/heads/master@{#305870}
6 years ago (2014-11-26 20:32:15 UTC) #9
gab
6 years ago (2014-12-02 21:56:33 UTC) #11
Message was sent while issue was closed.
Just had a thought, see inline below to avoid being bitten by a benign change in
the future.

https://codereview.chromium.org/759313002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/759313002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:56749: +  <int value="4"
label="chrome::RESULT_CODE_INVALID_CMDLINE_URL"/>
Be aware though that all codes below are subject to be bumped if
content::RESULT_CODE_LAST_CODE goes up (because of [1]).

I suggest adding a comment @ [2] to update this enum should it indeed be bumped
to avoid a headache looking for the wrong culprit if it does.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/chro...

[2]
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...

Also note that UMA doesn't have a nice way to provide histogram definitions per
milestone... so if someone correctly adjusts this on trunk, the dashboards will
be all messed up for values coming from Stable/Beta which would still be
reporting the "old" exit codes...

Powered by Google App Engine
This is Rietveld 408576698