pkg/compiler/lib/src/js_backend/codegen/codegen.dart - Issue 759193005: Add support for fields to the new dart backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 759193005: Add support for fields to the new dart backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix dart2js-cps Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

index 1eb0c335da60e8462b3e20fdedee90275718a7ab..44bad9f0f7857ad96166bd94916a78559c736cb2 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

@@ -96,7 +96,7 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {

String getVariableName(tree_ir.Variable variable) {

// TODO(sigurdm): Handle case where the variable belongs to an enclosing

// function.

- if (variable.host.element != currentFunction) giveup(variable);

+ if (variable.host != currentFunction) giveup(variable);

// Get the name if we already have one.

String name = variableNames[variable];